gatorsmile commented on a change in pull request #24842: [SPARK-28002][SQL] 
Support WITH clause column aliases
URL: https://github.com/apache/spark/pull/24842#discussion_r293274082
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql
 ##########
 @@ -24,6 +24,10 @@ SELECT t1.id AS c1,
 FROM   CTE1 t1
        CROSS JOIN CTE1 t2;
 
+-- CTE with column alias
+WITH t(x) AS (SELECT 1)
 
 Review comment:
   Could you add more test cases? For example, can a with clause in a subquery 
shadow a with clause in an enclosing query with the same name? Another example, 
use with clauses in a subquery expression?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to