HyukjinKwon commented on a change in pull request #24742: [SPARK-27881][SQL]
Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r293320402
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1272,7 +1272,8 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
* Create a [[Cast]] expression.
*/
override def visitCast(ctx: CastContext): Expression = withOrigin(ctx) {
- Cast(expression(ctx.expression), visitSparkDataType(ctx.dataType))
+ Cast(expression(ctx.expression()), visitSparkDataType(ctx.dataType),
Review comment:
Technically it's fine to change - otherwise, we will be stuck every time we
fix something even internal.
In practice, yes, some people use those internal catalyst APIs (as Max
pointed out, it's likely Cast is being used somewhere else). So, it's better to
avoid change it possible.
So, let's change when it's absolutely needed. I haven;t taken a close look
yet but let's change it if this is something inevitable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
