viirya commented on a change in pull request #24861: Continuation to
:[SPARK-26985][CORE] Fix "access only some column of the all of columns " for
big endian architecture BUG
URL: https://github.com/apache/spark/pull/24861#discussion_r293355358
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
##########
@@ -304,7 +304,7 @@ public static void throwException(Throwable t) {
static {
boolean _unaligned;
String arch = System.getProperty("os.arch", "");
- if (arch.equals("ppc64le") || arch.equals("ppc64")) {
+ if (arch.equals("ppc64le") || arch.equals("ppc64") ||
arch.matches("s390x")) {
// Since java.nio.Bits.unaligned() doesn't return true on ppc (See
JDK-8165231), but
// ppc64 and ppc64le support it
Review comment:
Not big deal, but if `s390x` is listed here because of the same reason
(`java.nio.Bits.unaligned() doesn't return true on`...), to update this comment
seems good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
