Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3945#discussion_r22677217
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrix.scala
 ---
    @@ -102,6 +102,8 @@ class IndexedRowMatrix(
           k: Int,
           computeU: Boolean = false,
           rCond: Double = 1e-9): SingularValueDecomposition[IndexedRowMatrix, 
Matrix] = {
    +
    +    require(k >= 1, "k should be at least one.")
    --- End diff --
    
    Could you please make this identical to the message from 
RowMatrix.computeSVD?  (It gives more info, printing out k and the number of 
columns.)  It would also be nice to change both to say "numCols" instead of "n"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to