srowen commented on a change in pull request #24857: [MINOR][CORE] Remove an
unused variable in SparkSubmt.scala
URL: https://github.com/apache/spark/pull/24857#discussion_r293440504
##########
File path:
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolMessage.scala
##########
@@ -46,9 +46,6 @@ private[rest] abstract class SubmitRestProtocolMessage {
val action: String = messageType
var message: String = null
- // For JSON deserialization
- private def setAction(a: String): Unit = { }
-
Review comment:
Agree, this might be used by reflection; I'd keep it unless we're very sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
