gengliangwang commented on a change in pull request #24768: [SPARK-27919][SQL]
Add v2 session catalog
URL: https://github.com/apache/spark/pull/24768#discussion_r293460884
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala
##########
@@ -17,17 +17,43 @@
package org.apache.spark.sql.catalog.v2
+import scala.util.control.NonFatal
+
import org.apache.spark.annotation.Experimental
+import org.apache.spark.internal.Logging
import org.apache.spark.sql.catalyst.TableIdentifier
/**
* A trait to encapsulate catalog lookup function and helpful extractors.
*/
@Experimental
-trait LookupCatalog {
+trait LookupCatalog extends Logging {
+
+ import LookupCatalog._
+ protected def defaultCatalogName: Option[String] = None
protected def lookupCatalog(name: String): CatalogPlugin
+ def defaultCatalog: Option[CatalogPlugin] = {
+ try {
+ defaultCatalogName.map(lookupCatalog)
+ } catch {
+ case NonFatal(e) =>
+ logError(s"Cannot load default v2 catalog: ${defaultCatalogName.get}",
e)
+ None
+ }
+ }
+
+ def sessionCatalog: Option[CatalogPlugin] = {
Review comment:
Maybe some comments for the `sessionCatalog`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
