jeremyjliu commented on a change in pull request #24811: [SPARK-27962][R][CORE]
Propagate subprocess stdout in deploy.RRunner in exception
URL: https://github.com/apache/spark/pull/24811#discussion_r293092782
##########
File path: core/src/main/scala/org/apache/spark/deploy/RRunner.scala
##########
@@ -100,15 +100,17 @@ object RRunner {
builder.redirectErrorStream(true) // Ugly but needed for stdout and
stderr to synchronize
val process = builder.start()
- new RedirectThread(process.getInputStream, System.out, "redirect R
output").start()
+ val stdoutBuffer = new CircularBuffer(1024)
Review comment:
I matched this to the size of the buffer within the RedirectThread, so at
this patch no I don't think that could happen. But, you're right in that this
could easily get out of sync in the future - perhaps pulling the buffer size to
a static variable in Utils.scala (or wherever is most appropriate) would
prevent that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
