Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3607#discussion_r22680079
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala ---
    @@ -87,6 +92,21 @@ private[spark] class ClientArguments(args: 
Array[String], sparkConf: SparkConf)
           throw new IllegalArgumentException(
             "You must specify at least 1 executor!\n" + getUsageMessage())
         }
    +    if (isClusterMode) {
    +      for (key <- Seq(amMemKey, amMemOverheadKey)) {
    +        if (sparkConf.getOption(key).isDefined) {
    +          println(s"$key is set but does not apply in cluster mode.")
    --- End diff --
    
    I don't think you want to use `println` here. Also, I'm always a little 
conflicted about these logs, since they'll show up when you set these values in 
the default conf file (which would apply to a lot of different jobs unless they 
explicitly override the conf file). But not a big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to