Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3949#discussion_r22681035
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
    @@ -228,6 +228,29 @@ private[spark] object BLAS extends Serializable with 
Logging {
         }
         _nativeBLAS
       }
    + 
    +  /**
    +   * A := alpha * x * x^T + A
    +   */
    +  def dsyr(alpha: Double, x: DenseVector, A: DenseMatrix) {
    --- End diff --
    
    Can you please rename this to ```syr``` (no "d") since the "d" refers to 
double-precision (and the type is specified by the given types anyways)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to