srowen commented on a change in pull request #24702: [SPARK-27989] [Kubernetes]
[Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r293913767
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
##########
@@ -172,10 +172,13 @@ public TransportClient createClient(String remoteHost,
int remotePort)
final long preResolveHost = System.nanoTime();
final InetSocketAddress resolvedAddress = new
InetSocketAddress(remoteHost, remotePort);
final long hostResolveTimeMs = (System.nanoTime() - preResolveHost) /
1000000;
+ final String resolvMsg = resolvedAddress.isUnresolved() ? "failed" :
"succeed";
if (hostResolveTimeMs > 2000) {
- logger.warn("DNS resolution for {} took {} ms", resolvedAddress,
hostResolveTimeMs);
+ logger.warn("DNS resolution {} for {} took {} ms",
+ resolvMsg, resolvedAddress, hostResolveTimeMs);
Review comment:
The indent is too deep; can it just do on the previous line? if not
continuation indent is at most 4 spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
