abellina commented on a change in pull request #24795: [SPARK-27945][SQL]
Minimal changes to support columnar processing
URL: https://github.com/apache/spark/pull/24795#discussion_r293931685
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
##########
@@ -1270,6 +1273,211 @@ class ColumnarBatchSuite extends SparkFunSuite {
allocator.close()
}
+ test("RowToColumnarExec") {
Review comment:
So I think overall this test is replicating some of what `RowToColumnarExec`
does, but not calling into it. We should change the name for this test to
something like "testing InternalRow to ColumnVector conversion"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
