abellina edited a comment on issue #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing URL: https://github.com/apache/spark/pull/24795#issuecomment-502239885 Thanks for addressing the review comments @revans2. I am +1 (non binding). I can't count myself as a catalyst expert, and so I hope we get some more folks here to take a look, but overall I think it makes sense how it fits into the existing code. I think this is a clean way to add plugins, and the interface is clean. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
