skonto edited a comment on issue #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver URL: https://github.com/apache/spark/pull/24796#issuecomment-501593451 @zsxwing we can only fix the related issue here, just avoid the deadlock so shutdown is finished. As for the generic case I dont see why this thread is not interrupted maybe because this is a special case when handling an Uncaught Exception via a handler coming from the thread it caused it. I will check what jvm does in this case but if there is anyone who knows more feel free to call him here. Probably hitting this one: https://bugs.openjdk.java.net/browse/JDK-8154017 mentioned here:https://github.com/jacoco/jacoco/issues/394#issuecomment-208531845. The fix in there ignores all interrupts until the hooks are completed (we call exit as well) so since the uncaught exception handler executes a shutdownhook from the event loop thread, that thread cannot be interrupted. @shipilev Hi ! I saw you reported that error and also discussed the related fix, any help would be great as I dont have the rights to comment to the ticket directly. Another question is do we have this pattern elsewhere like Master,Worker or Executor where there is already a handler? @srowen also thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
