srowen commented on a change in pull request #24843: [SPARK-28004][UI] Update
jquery to 3.4.1
URL: https://github.com/apache/spark/pull/24843#discussion_r294049535
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -366,9 +367,8 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
contextHandler.addServlet(holder, "/")
server.attachHandler(contextHandler)
- implicit val webDriver: WebDriver = new HtmlUnitDriver(true) {
- getWebClient.getOptions.setThrowExceptionOnScriptError(false)
- }
+ implicit val webDriver: WebDriver =
Review comment:
One last clarifying comment: This change slightly improves the test to _not_
ignore javascript errors, and as part of that, needed to test as a modern
browser (IE 11 vs IE 8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
