dongjoon-hyun commented on issue #24884: [SPARK-28066][CORE] Optimize UTF8String.trim() for common case of no whitespace URL: https://github.com/apache/spark/pull/24884#issuecomment-502541397 Thank you for updating, @srowen . The sentence looks correct since it describes the content of the return value. However, can we explicitly describe both `return this` and `the memory copy` cases separately? `@return this string` seems to give an impression to reuse the underlying memory space. But, we do copy for the 10% of the input strings.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
