MaxGekk commented on issue #24889: [SPARK-28072][SQL] Use 
`Iso8601TimestampFormatter` in `FromUnixTime` codegen to fix ICCE in JDK9+
URL: https://github.com/apache/spark/pull/24889#issuecomment-502601330
 
 
   @dongjoon-hyun I grep-ed by `TimestampFormatter.getClass`, and found similar 
places:
   1. 
https://github.com/apache/spark/blob/79d3bc0409ccf978126d9c2bc0740ace196fe55b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L543-L547
   2. 
https://github.com/apache/spark/blob/79d3bc0409ccf978126d9c2bc0740ace196fe55b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L719-L723
   
   Should we change them as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to