srowen commented on a change in pull request #24889: [SPARK-28072][SQL] Use
`Iso8601TimestampFormatter` in `FromUnixTime` codegen to fix ICCE in JDK9+
URL: https://github.com/apache/spark/pull/24889#discussion_r294291296
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -859,11 +859,11 @@ case class FromUnixTime(sec: Expression, format:
Expression, timeZoneId: Option[
} else {
val zid = ctx.addReferenceObj("zoneId", zoneId, classOf[ZoneId].getName)
val locale = ctx.addReferenceObj("locale", Locale.US)
- val tf = TimestampFormatter.getClass.getName.stripSuffix("$")
+ val tf = classOf[Iso8601TimestampFormatter].getName
Review comment:
From my understanding, it's not a bug in the JVM; the failure is (now)
correct, so we need to fix here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
