Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3638#discussion_r22693694
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -266,8 +266,21 @@ private[spark] class TaskSchedulerImpl(
                   assert(availableCpus(i) >= 0)
                   launchedTask = true
                 }
    +          } catch {
    +            case e: TaskNotSerializableException => {
    +              logError(s"Resource offer failed, task set ${taskSet.name} 
was not serializable")
    +              // Do not offer resources for this task, but don't throw an 
error to allow other
    +              // task sets to be submitted.
    +              return
    +            }
               }
             }
    +      }
    +    }
    --- End diff --
    
    can you define this function as a `private def` outside of 
`resourceOffers`? The nesting here makes this hard to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to