srowen commented on a change in pull request #22502: [SPARK-25474][SQL]When the
"fallBackToHdfsForStats= true", Size in bytes is coming as default size in
bytes ( 8.0 EB)
URL: https://github.com/apache/spark/pull/22502#discussion_r294304930
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
##########
@@ -86,10 +89,28 @@ case class HadoopFsRelation(
}
override def sizeInBytes: Long = {
- val compressionFactor = sqlContext.conf.fileCompressionFactor
- (location.sizeInBytes * compressionFactor).toLong
+ val isCatalogFileIndex = location.isInstanceOf[CatalogFileIndex]
+ if (sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled &&
isCatalogFileIndex) {
+ sizeInBytesFallBackToHdfs
+ } else {
+ val compressionFactor = sqlContext.conf.fileCompressionFactor
+ (location.sizeInBytes * compressionFactor).toLong
+ }
}
+ private def sizeInBytesFallBackToHdfs: Long = {
Review comment:
Rather than repeat the 'compression' part here, you could inline this
method, `return` from the try block, and ignore the exception, falling through
to a default return value with the 'compression' logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
