srowen commented on a change in pull request #24893: [SPARK-28081][ML] Handle
large vocab counts in word2vec
URL: https://github.com/apache/spark/pull/24893#discussion_r294333963
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala
##########
@@ -268,6 +268,8 @@ class Word2Vec extends Serializable with Logging {
min2i = pos2
pos2 += 1
}
+ assert(count(min1i) < Long.MaxValue)
Review comment:
I may remove these asserts before we commit; just a double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
