jlpedrosa commented on a change in pull request #24702: [SPARK-27989] 
[Kubernetes] [Core] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r294346635
 
 

 ##########
 File path: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
 ##########
 @@ -78,6 +78,16 @@ case "$1" in
       -Xms$SPARK_EXECUTOR_MEMORY
       -Xmx$SPARK_EXECUTOR_MEMORY
       -cp "$SPARK_CLASSPATH"
+     )
+
+    #Disable negative dns reslolution 
https://docs.oracle.com/javase/8/docs/technotes/guides/net/properties.html if 
that property is defined
 
 Review comment:
   hi @srowen 
   
   Now I understand what you mean, "here" means this PR or jira ticket (please 
correct me if I miss understood you). Then no worries, I'll keep the retries 
only in this one and then start a new PR/Jira process to discuss the DNS, and 
see what and where we can do.
   In my opinion retries make sense, avoid rescheduling something for a 
transient error that is recoverable is helpful, this is not multi layered 
system so it can't storm out.
   
   I've re-written history into a single commit to make it cleaner.
   
   JL

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to