Github user etrain commented on the pull request:
https://github.com/apache/spark/pull/3637#issuecomment-69275360
I've left a set of comments on the changes as they are. At a high level
these APIs feel heavy and there seem to be a lot of things you have to get just
right to add a new algorithm. Some of these aren't enforced at compile time,
which makes me wonder if there's not a better class hierarchy we can use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
