Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3638#discussion_r22694961
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -865,26 +865,6 @@ class DAGScheduler(
}
if (tasks.size > 0) {
- // Preemptively serialize a task to make sure it can be serialized.
We are catching this
- // exception here because it would be fairly hard to catch the
non-serializable exception
- // down the road, where we have several different implementations
for local scheduler and
- // cluster schedulers.
- //
- // We've already serialized RDDs and closures in taskBinary, but
here we check for all other
- // objects such as Partition.
- try {
- closureSerializer.serialize(tasks.head)
- } catch {
- case e: NotSerializableException =>
- abortStage(stage, "Task not serializable: " + e.toString)
- runningStages -= stage
- return
- case NonFatal(e) => // Other exceptions, such as
IllegalArgumentException from Kryo.
- abortStage(stage, s"Task serialization failed:
$e\n${e.getStackTraceString}")
- runningStages -= stage
- return
- }
-
--- End diff --
Can you explain why this is removed? It used to provide a way to fail fast
if the task is not serializable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
