cloud-fan commented on a change in pull request #24900: [SPARK-28089][SQL] File
source v2: support reading output of file streaming Sink
URL: https://github.com/apache/spark/pull/24900#discussion_r295100493
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
##########
@@ -512,3 +429,174 @@ class FileStreamSinkSuite extends StreamTest {
}
}
}
+
+class FileStreamSinkV1Suite extends FileStreamSinkSuite {
+ import testImplicits._
+
+ override protected def sparkConf: SparkConf =
+ super
+ .sparkConf
+ .set(SQLConf.USE_V1_SOURCE_READER_LIST, "csv,json,orc,text,parquet")
+ .set(SQLConf.USE_V1_SOURCE_WRITER_LIST, "csv,json,orc,text,parquet")
+
+ test("partitioned writing and batch reading") {
Review comment:
can you highlight the difference between this test case and the one in
`FileStreamSinkV2Suite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]