WeichenXu123 commented on a change in pull request #24830:
[SPARK-27990][SQL][ML] Provide a way to recursively load data from datasource
URL: https://github.com/apache/spark/pull/24830#discussion_r295114650
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -572,6 +573,75 @@ class FileBasedDataSourceSuite extends QueryTest with
SharedSQLContext with Befo
}
}
+ test("Option recursiveFileLookup: recursive loading correctly") {
+
+ val expectedFileList = mutable.ListBuffer[String]()
+
+ def createFile(dir: File, fileName: String, format: String): Unit = {
+ val path = new File(dir, s"${fileName}.${format}")
+ Files.write(
+ path.toPath,
+ s"content of ${path.toString}".getBytes,
+ StandardOpenOption.CREATE, StandardOpenOption.WRITE
+ )
+ val fsPath = new Path(path.getAbsoluteFile.toURI).toString
+ expectedFileList.append(fsPath)
+ }
+
+ def createDir(path: File, dirName: String, level: Int): Unit = {
+ val dir = new File(path, s"dir${dirName}-${level}")
+ dir.mkdir()
+ createFile(dir, s"file${level}", "bin")
+ createFile(dir, s"file${level}", "text")
+
+ if (level < 4) {
+ // create sub-dir
+ createDir(dir, "sub0", level + 1)
+ createDir(dir, "sub1", level + 1)
+ }
+ }
+
+ withTempPath { path =>
Review comment:
There's a line `path.delete` inside `withTempDir`.
```
protected def withTempPath(f: File => Unit): Unit = {
val path = Utils.createTempDir()
path.delete()
try f(path) finally Utils.deleteRecursively(path)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
