hvanhovell commented on a change in pull request #22054: [SPARK-24703][SQL]:
To add support to multiply CalendarInterval with Integral Type.
URL: https://github.com/apache/spark/pull/22054#discussion_r295529358
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -211,14 +211,58 @@ case class Subtract(left: Expression, right: Expression)
extends BinaryArithmeti
""")
case class Multiply(left: Expression, right: Expression) extends
BinaryArithmetic {
Review comment:
Adding interval scaling here violates the BinaryArithmetic/BinaryOperator
contract. We should use a different expression, and convert in the analyzer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
