Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3926#discussion_r22703535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SparkSQLParser.scala
---
@@ -25,15 +25,51 @@ import scala.util.parsing.input.CharArrayReader.EofCh
import org.apache.spark.sql.catalyst.plans.logical._
-private[sql] abstract class AbstractSparkSQLParser
+private[sql] trait KeywordNormalizer {
+ def apply(str: String): String = str
+}
+
+private[sql] object CaseInsensitive extends KeywordNormalizer {
+ override def apply(str: String) = str.toLowerCase()
+}
+
+private[sql] object CaseSensitive extends KeywordNormalizer {
+ override def apply(str: String) = str
+}
+
+// TODO make the normalizer configurable?
+private[sql] abstract class AbstractSparkSQLParser(normalizer:
KeywordNormalizer = CaseInsensitive)
extends StandardTokenParsers with PackratParsers {
- def apply(input: String): LogicalPlan = phrase(start)(new
lexical.Scanner(input)) match {
- case Success(plan, _) => plan
- case failureOrError => sys.error(failureOrError.toString)
+ def apply(input: String): LogicalPlan = {
--- End diff --
You're right, we probably can combine couple of `Parser` work in delegation
mode, but currently, I just simply wrote another version of the `def apply` in
`DDLParser`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
