priyankagargnitk commented on a change in pull request #22054:
[SPARK-24703][SQL]: To add support to multiply CalendarInterval with Integral
Type.
URL: https://github.com/apache/spark/pull/22054#discussion_r295694734
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -211,14 +211,58 @@ case class Subtract(left: Expression, right: Expression)
extends BinaryArithmeti
""")
case class Multiply(left: Expression, right: Expression) extends
BinaryArithmetic {
Review comment:
I have started creating a new expression rather than making changes in the
Multiply expression. Meanwhile, I am not sure how we will map "*" to "Multiply"
and "MultiplyInterval" expression based on the parameter datatypes. I can see
in function Registry that multiple function names can be mapped to the same
expression, but I don't see any symbol to be mapped to do different expressions
based on the parameters. Can you please share an example where this is
happening already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
