skambha commented on issue #24593: [SPARK-27692][SQL] Add new optimizer rule to evaluate the deterministic scala udf only once if all inputs are literals URL: https://github.com/apache/spark/pull/24593#issuecomment-504116415 Hi @HyukjinKwon , Thanks for your comments. This has the summary of the discussion so far: https://github.com/apache/spark/pull/24593#issuecomment-492448836 and https://github.com/apache/spark/pull/24593#issuecomment-493704947 > Why don't we consider #24593 (comment)? @gatorsmile says “I am against the changes for automatically folding the ScalaUDF” is against doing this in this comment https://github.com/apache/spark/pull/24593#pullrequestreview-237361795 Although technically we can approach it this way, but per this comment, IIUC, we do not want to go down this path. > Otherwise, this rule looks too specific to one case. Actually the rule will work for different cases in combination with the constant folding rule for nested expressions that are foldable etc. If you have a specific scenario that you would like to be covered, please let me know.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
