dongjoon-hyun commented on a change in pull request #24908:
[SPARK-28093][SPARK-28109][SQL][2.3] Fix TRIM/LTRIM/RTRIM function parameter
order issue
URL: https://github.com/apache/spark/pull/24908#discussion_r296103528
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -752,7 +752,7 @@ nonReserved
| UNBOUNDED | WHEN
| DATABASE | SELECT | FROM | WHERE | HAVING | TO | TABLE | WITH | NOT
| DIRECTORY
- | BOTH | LEADING | TRAILING
+ | TRIM | BOTH | LEADING | TRAILING
Review comment:
@wangyum .
I agree your intention because this location might be better. However, we
consider the ordering seriously during `backporting` .
`master` branch had better resemble `branch-2.4`. `branch-2.4` branch had
better reusable `branch-2.3`. Please follow the nearest branch. In this case,
`branch-2.4`. Please put the change to the closest line compared with
`branch-2.4`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
