gatorsmile commented on a change in pull request #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#discussion_r296502762
########## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ########## @@ -89,16 +89,25 @@ struct<c1:int,c2:int> -- !query 7 -DROP VIEW IF EXISTS t +WITH t(x) AS (SELECT 1) +SELECT * FROM t WHERE x = 1 Review comment: Almost all the test cases are using one column in the CTE definition. Can you try your best to improve the current test coverage in this new syntax? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
