mgaido91 commented on issue #24940: [SPARK-28135] Better double support in SQL ceil/floor functions URL: https://github.com/apache/spark/pull/24940#issuecomment-504888907 I think Spark should not be bound completely to Hive's behavior. Most of other SQL engines work properly in this case and it is a correctness issue. My main doubts regard the behavior change which the PR introduces: the return type of the function is different and this may break running workloads. Since the next release is going to be 3.0, it may be considered fine, but at very least we need to add a statement in the migration guide. Moreover we would also need a test in order to enforce the behavior in those cases.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
