gaborgsomogyi commented on issue #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#issuecomment-504967700 @itsvikramagr thanks for the hard work! The presentations rocks and helps to understand the design but it will take some time to analyze things properly. I think it's a good feature so will review it through. Initially I have these suggestions/questions: * Please resolve style problems (not just the ones which made the build fail, please see contribution guide for details. As an example number of tabs are incorrect consistently when parameters are broken into multiple lines) * Do we have some numbers about the performance impact? * Related testing part do I understand correctly you've not tested it on cluster with heavy load (and maybe with artificial exceptions)?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
