squito commented on a change in pull request #24834: [SPARK-27992][PYTHON]
Synchronize with Python connection thread to propagate errors
URL: https://github.com/apache/spark/pull/24834#discussion_r296803150
##########
File path: python/pyspark/rdd.py
##########
@@ -159,7 +174,8 @@ class PyLocalIterable(object):
""" Create a synchronous local iterable over a socket """
def __init__(self, _sock_info, _serializer):
- self._sockfile = _create_local_socket(_sock_info)
+ port, auth_secret, self.jserver_obj = _sock_info
Review comment:
just a general comment, might not make the most sense to address in this
particular PR -- I'd find it really helpful if the python code which is dealing
w/ java objects would annotate (somehow) the java types. Its hard for me to
figure out if `jserver_obj` is a ServerSocket or a SocketAuthServer or
Py4JJavaServer etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
