erikerlandson commented on a change in pull request #24879: [SPARK-28042][K8S]
Support using hostpath volume mount as local storage
URL: https://github.com/apache/spark/pull/24879#discussion_r296881446
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala
##########
@@ -43,33 +44,52 @@ private[spark] class LocalDirsFeatureStep(
val localDirVolumes = resolvedLocalDirs
.zipWithIndex
.map { case (localDir, index) =>
- new VolumeBuilder()
- .withName(s"spark-local-dir-${index + 1}")
- .withNewEmptyDir()
- .withMedium(if (useLocalDirTmpFs) "Memory" else null)
- .endEmptyDir()
- .build()
+ val name = s"spark-local-dir-${index + 1}"
+ findVolume(pod, name) match {
+ case Some(volume) => volume
Review comment:
integration tests should exercise both cases (found the volume or created
it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
