vanzin commented on a change in pull request #24804: [SPARK-23472][CORE] Add
defaultJavaOptions for driver and executor.
URL: https://github.com/apache/spark/pull/24804#discussion_r296955715
##########
File path:
core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala
##########
@@ -289,6 +289,70 @@ class ConfigEntrySuite extends SparkFunSuite {
assert(conf.get(iConf) === 3)
}
+ test("conf entry: prepend with default separator") {
Review comment:
Should probably add a test for the "fallback conf" case, since it's a little
odd. If I follow the current code, it will not fallback if either the conf or
the "prepend" conf are set (which is fine, it just would be good to have a
test).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
