cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] 
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r296983519
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/network/BlockDataManager.scala
 ##########
 @@ -32,6 +32,12 @@ trait BlockDataManager {
    */
   def getBlockData(blockId: BlockId): ManagedBuffer
 
+  /**
+   * Interface to get shuffle block data. Throws an exception if the block 
cannot be found or
+   * cannot be read successfully.
+   */
+  def getShuffleBlockData(blockId: BlockId, shuffleGenerationId: Int): 
ManagedBuffer
 
 Review comment:
   BTW, can we just define it as `def getShuffleBlockData(shuffleId: Int, 
shuffleGenerationId: Int, mapId: Int, reducerId: Int)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to