cloud-fan commented on a change in pull request #24947: [SPARK-28143][SQL]IN
expression missing attribute should throw analysis exception
URL: https://github.com/apache/spark/pull/24947#discussion_r296992423
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -583,7 +583,9 @@ object FunctionRegistry {
val validParametersCount = constructors
.filter(_.getParameterTypes.forall(_ == classOf[Expression]))
.map(_.getParameterCount).distinct.sorted
- val expectedNumberOfParameters = if (validParametersCount.length ==
1) {
+ val expectedNumberOfParameters = if (validParametersCount.length ==
0) {
+ throw new AnalysisException(s"$name is an invalid function.")
+ } else if (validParametersCount.length == 1) {
validParametersCount.head.toString
} else {
validParametersCount.init.mkString("one of ", ", ", " and ") +
Review comment:
can we just handle empty `validParametersCount` here? I think it's better to
have a unified error message:
```
Invalid number of arguments for function $name. Expected .....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
