dbtsai commented on a change in pull request #24957: [SPARK-27100][SQL][2.4] Use `Array` instead of `Seq` in `FilePartition` to… URL: https://github.com/apache/spark/pull/24957#discussion_r297042463
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala ########## @@ -53,12 +53,6 @@ case class PartitionedFile( } } -/** - * A collection of file blocks that should be read as a single task - * (possibly from multiple partitioned directories). - */ -case class FilePartition(index: Int, files: Seq[PartitionedFile]) extends RDDPartition Review comment: Do we need to have those changes as @dongjoon-hyun suggested? Why not just change `Seq` to `Array` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
