xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r297047538
##########
File path:
core/src/main/scala/org/apache/spark/network/BlockTransferService.scala
##########
@@ -66,6 +66,7 @@ abstract class BlockTransferService extends ShuffleClient
with Closeable with Lo
host: String,
port: Int,
execId: String,
+ shuffleGenerationId: Int,
Review comment:
This `fetchBlocks` override from `ShuffleClient`, and it only used fetching
non-shuffle blocks in `fetchBlockSync`, so maybe we add a comment in
fetchBlockSync and point this out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
