dongjoon-hyun commented on a change in pull request #24966: [SPARK-28157][CORE]
Make SHS clear KVStore LogInfo for the expired blacklist entries
URL: https://github.com/apache/spark/pull/24966#discussion_r297116887
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
##########
@@ -1141,7 +1139,10 @@ class FsHistoryProviderSuite extends SparkFunSuite with
Matchers with Logging {
assert(mockedProvider.isBlacklisted(accessDeniedPath))
clock.advance(24 * 60 * 60 * 1000 + 1) // add a bit more than 1d
mockedProvider.cleanLogs()
- assert(!mockedProvider.isBlacklisted(accessDeniedPath))
+ updateAndCheck(mockedProvider) { list =>
+ assert(!mockedProvider.isBlacklisted(accessDeniedPath))
+ list.size should be(2)
Review comment:
Previously, this always 1 because the newly released `accessDeniedPath` is
ignored by `shouldReloadLog` due to the unchanged size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
