HyukjinKwon commented on a change in pull request #24898: [SPARK-22340][PYTHON] 
Add a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#discussion_r297454848
 
 

 ##########
 File path: python/pyspark/tests/test_context.py
 ##########
 @@ -213,6 +213,10 @@ def test_progress_api(self):
             rdd = sc.parallelize(range(10)).map(lambda x: time.sleep(100))
 
             def run():
+                # When thread is pinned, job group should be set for each 
thread for now.
+                # Local properties seem not being inherited like Scala side 
does.
+                if os.environ.get("PYSPARK_PIN_THREAD", "false").lower() != 
"true":
 
 Review comment:
   Damn .. yes, it's a typo.. I was testing all PySpark tests when enabling 
this and forgot to bring this back .. thanks for catching this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to