gatorsmile commented on a change in pull request #24886: [SPARK-28054][SQL] Fix 
error when insert Hive partitioned table dynamically where partition name is 
upper case
URL: https://github.com/apache/spark/pull/24886#discussion_r297462022
 
 

 ##########
 File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
 ##########
 @@ -1188,6 +1188,24 @@ class HiveQuerySuite extends HiveComparisonTest with 
SQLTestUtils with BeforeAnd
       }
     }
   }
+
+  test("SPARK-28054: Unable to insert partitioned table when partition name is 
upper case") {
+    withTable("spark_28054_test") {
+      sql("set hive.exec.dynamic.partition.mode=nonstrict")
 
 Review comment:
   Should we set it back?
   
   Use withSQLConf ?
   
   Also do we need to set the case sensitivity conf?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to