Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3987#discussion_r22753194
--- Diff:
sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala ---
@@ -53,7 +53,7 @@ import scala.language.implicitConversions
*
* @param functionClassName UDF class name
*/
-class HiveFunctionWrapper(var functionClassName: String) extends
java.io.Externalizable {
+case class HiveFunctionWrapper(var functionClassName: String) extends
java.io.Externalizable {
--- End diff --
Yeah, its mutated below by our custom deserialization.
On Jan 9, 2015 4:31 PM, "Kousuke Saruta" <[email protected]> wrote:
> In sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala
> <https://github.com/apache/spark/pull/3987#discussion-diff-22753114>:
>
> > @@ -53,7 +53,7 @@ import scala.language.implicitConversions
> > *
> > * @param functionClassName UDF class name
> > */
> > -class HiveFunctionWrapper(var functionClassName: String) extends
java.io.Externalizable {
> > +case class HiveFunctionWrapper(var functionClassName: String) extends
java.io.Externalizable {
>
> nit: should functionClassName be still var?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3987/files#r22753114>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
