srowen commented on a change in pull request #22502: [SPARK-25474][SQL]When the
"fallBackToHdfsForStats= true", Size in bytes is coming as default size in
bytes ( 8.0 EB)
URL: https://github.com/apache/spark/pull/22502#discussion_r297698286
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
##########
@@ -70,8 +72,16 @@ case class HadoopFsRelation(
}
override def sizeInBytes: Long = {
+ val isCatalogFileIndex = location.isInstanceOf[CatalogFileIndex]
val compressionFactor = sqlContext.conf.fileCompressionFactor
- (location.sizeInBytes * compressionFactor).toLong
+ val defaultSize = (location.sizeInBytes * compressionFactor).toLong
+
Review comment:
```
location match {
case cfi: CatalogFileIndex if
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
DDLUtils...
case _ => defaultSize
}
```
maybe?
Does it make sense to push the check for
`sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled` into the method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
