dongjoon-hyun commented on a change in pull request #24860: [SPARK-28034][SQL] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r297858102
########## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ########## @@ -0,0 +1,1216 @@ +-- +-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group +-- +-- +-- WITH +-- https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/with.sql + +-- +-- Tests for common table expressions (WITH query, ... SELECT ...) +-- + +-- Basic WITH +-- [ORIGINAL SQL] +--WITH q1(x,y) AS (SELECT 1,2) +--SELECT * FROM q1, q1 AS q2; +WITH q1(x,y) AS (SELECT 1,2) +SELECT * FROM q1 CROSS JOIN q1 AS q2; Review comment: According to the `case.sql`, it seems that we prefer to use `crossJoin.enabled` at the beginning and at the end. ``` set spark.sql.crossJoin.enabled=true; ... set spark.sql.crossJoin.enabled=false; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
