vanzin commented on a change in pull request #24970: [SPARK-23977][SQL] Support High Performance S3A committers URL: https://github.com/apache/spark/pull/24970#discussion_r297870768
########## File path: hadoop-cloud/src/hadoop-3/main/scala/org/apache/spark/internal/io/cloud/BindingParquetOutputCommitter.scala ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.internal.io.cloud + +import java.io.IOException + +import org.apache.hadoop.fs.Path +import org.apache.hadoop.mapreduce.lib.output.{BindingPathOutputCommitter, PathOutputCommitter} +import org.apache.hadoop.mapreduce.{JobContext, JobStatus, TaskAttemptContext} +import org.apache.parquet.hadoop.ParquetOutputCommitter + +import org.apache.spark.internal.Logging + +/** + * This Parquet Committer subclass dynamically binds to the factory-configured + * output committer, and is intended to allow callers to use any [[PathOutputCommitter]], + * even if not a subclass of [[ParquetOutputCommitter]]. + * + * The Parquet `parquet.enable.summary-metadata` option will only be supported + * if the instantiated committer itself supports it. + */ +class BindingParquetOutputCommitter( + path: Path, + context: TaskAttemptContext) + extends ParquetOutputCommitter(path, context) with Logging { + + logDebug(s"${this.getClass.getName} binding to configured PathOutputCommitter and dest $path") + + val committer = new BindingPathOutputCommitter(path, context) + + /** + * This is the committer ultimately bound to. + * @return the committer instantiated by the factory. + */ + def boundCommitter(): PathOutputCommitter = { + committer.getCommitter() + } + + override def getWorkPath: Path = { Review comment: add `()` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
