hvanhovell commented on a change in pull request #24978: [SPARK-28177][SQL]
Adjust post shuffle partition number in adaptive execution
URL: https://github.com/apache/spark/pull/24978#discussion_r298048832
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -293,27 +293,27 @@ object SQLConf {
.bytesConf(ByteUnit.BYTE)
.createWithDefault(64 * 1024 * 1024)
- val RUNTIME_REOPTIMIZATION_ENABLED =
- buildConf("spark.sql.runtime.reoptimization.enabled")
- .doc("When true, enable runtime query re-optimization.")
- .booleanConf
- .createWithDefault(false)
-
val ADAPTIVE_EXECUTION_ENABLED = buildConf("spark.sql.adaptive.enabled")
Review comment:
+1. Being a bit pedantic here, but let's try to do orthogonal changes like
removing the `RUNTIME_REOPTIMIZATION_ENABLED` flag in separate PRs. That makes
the cognitive load of reviewing lower, and it also improves git blame.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
