JoshRosen commented on a change in pull request #21599: [SPARK-26218][SQL]
Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#discussion_r298239713
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1719,6 +1719,14 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val ARITHMETIC_OPERATION_OVERFLOW_CHECK =
buildConf("spark.sql.arithmetic.checkOverflow")
+ .doc("If it is set to true (default), all arithmetic operations on
non-decimal fields throw " +
Review comment:
Should we default this to `true` in this PR? Or defer the change of default
to a separate PR?
Deferring the change of default would be consistent with the approach taken
in the DecimalType PR and we can always flip the default in a separate PR (at
which point we can write a migration guide note, too).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
