srowen commented on a change in pull request #24982: [SPARK-28181][CORE] Add a
filter interface to KVStore to speed up the entities retrieve
URL: https://github.com/apache/spark/pull/24982#discussion_r298256929
##########
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/InMemoryStore.java
##########
@@ -106,6 +106,12 @@ public void delete(Class<?> type, Object naturalKey) {
return list != null ? list.view() : emptyView();
}
+ @Override
+ public <T> KVStoreView<T> viewWithCondition(Class<T> type, Predicate<T>
condition) {
+ InstanceList<T> list = inMemoryLists.get(type);
Review comment:
You can't create a default parameter value, but you can keep both methods.
I'm just suggesting there's no need to duplicate their logic here and in
subclasses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
